search

inotia00 / rvx-builder

A NodeJS ReVanced Extended builder
GNU General Public License v3.0
589 stars 51 forks source link

TypeError: patches.compatiblePackages is not iterable #115

Closed TheRedNet closed 1 year ago

TheRedNet commented 1 year ago

Describe the bug Failure after download of dependencies

To Reproduce Steps to reproduce the behavior:

  1. Change source organization to 'ReVanced'
  2. Click on 'StartPatching'
  3. Wait for dependency download to finish
  4. Click 'Continue'
  5. See error

Screenshots image

revanced-builder Version: v3.9.15

Desktop (please complete the following information):

ntcong commented 1 year ago

looks like revanced-patches changed missing patch options from empty array to null which broke patch iteration in several places.

auanasgheps commented 1 year ago

I have the same issue, let's wait for the maintainer to comment.

inotia00 commented 1 year ago

fixed in rvx-builder-v3.10.0

auanasgheps commented 1 year ago

As usual, thank you for your fast response!

auanasgheps commented 1 year ago

Hi, I have updated to builder v3.10 but I'm still getting the error: image

inotia00 commented 1 year ago

ah, the reason I closed this issue is because the same issue was reproduced in the RVX patch using CLI v4.0 and I fixed it. (i.e. I solved the issue in the RVX patch)

Compatibility with official ReVanced sources is not guaranteed

ntcong commented 1 year ago

I can confirm it's working for revanced sources, the above comment probably left something not upgraded.

inotia00 commented 1 year ago

tbh I don't use the official ReVanced source Since some people seem to want it, I added compatibility with the official ReVanced source in rvx-builder-v3.10.1