inotia00 / rvx-builder

A NodeJS ReVanced Extended builder
GNU General Public License v3.0
531 stars 48 forks source link

Error building #28

Closed nobl55 closed 1 year ago

nobl55 commented 1 year ago

while building youtube revanced extended with v. 17.49.37

An error occured:TypeError: Cannot read properties of undefined (reading 'replace')at outputName (/data/data/com.termux/files/home/rvx-builder/wsEvents/patchApp.js:94:35)at afterBuild (/data/data/com.termux/files/home/rvx-builder/wsEvents/patchApp.js:29:3)at Socket.

nobl55 commented 1 year ago

while patching i also get a warning aapt2 w unknown chunk type 200

i reinstalled everything including termux

ryzen23 commented 1 year ago

works fine on me try the build version on pc

Spoderman1997 commented 1 year ago

1

Spacellary commented 1 year ago

Could to be related or the same thing as to https://github.com/reisxd/revanced-builder/issues/615 upstream.
A fix (https://github.com/reisxd/revanced-builder/commit/585c7748d3d5a0498d07c4dbc5511fd34ccfe2a7) was already implemented upstream and could be applied.


For those having the issue, when you are able to, also try it with reisxd's revanced builder and check if it is also reproduced there. It may not be only a rvx-builder specific issue and would be useful to also raise the issue there, if reproduced of course, since that's what the rvx-builder is built from.

PSA: return-youtube-dislike failling with reisxd's revanced-builder is a known issue, and was/is a problem with the official revanced-cli, it was fixed but a release wasn't pushed yet. It's not a problem with inotia00's builder since he compiled the fixed version (I think?) to be used with the RVX-builder. Thank you, inotia00!

Also when possible if you can add your system information like what Android/OS version you're running as it may help them narrow it down a bit more for a fix if necessary.


I also did a few tests, building Youtube and Youtube-Music in both reisxd's revanced-builder-linux and with rvx-builder-linux in v3.7.0 and I could not experience this issue in a Linux environment running Ubuntu (WSL2), which I think is closest to what is being reported here.

System: Windows 11 22H2 (22621.963)
Environment: Ubuntu 22.04.1 LTS (WSL2)
dannymirxa commented 1 year ago

Could to be related or the same thing as to reisxd#615 upstream.

A fix (reisxd@585c774) was already implemented upstream and could be applied.

For those having the issue, when you are able to, also try it with reisxd's revanced builder and check if it is also reproduced there. It may not be only a rvx-builder specific issue and would be useful to also raise the issue there, if reproduced of course, since that's what the rvx-builder is built from.

PSA: return-youtube-dislike failling with reisxd's revanced-builder is a known issue, and was/is a problem with the official revanced-cli, it was fixed but a release wasn't pushed yet. It's not a problem with inotia00's builder since he compiled the fixed version (I think?) to be used with the RVX-builder. Thank you, inotia00!

Also when possible if you can add your system information like what Android/OS version you're running as it may help them narrow it down a bit more for a fix if necessary.

I also did a few tests, building Youtube and Youtube-Music in both reisxd's revanced-builder-linux and with rvx-builder-linux in v3.7.0 and I could not experience this issue in a Linux environment running Ubuntu (WSL2), which I think is closest to what is being reported here.

System: Windows 11 22H2 (22621.963)

Environment: Ubuntu 22.04.1 LTS (WSL2)

Tested in my phone, yes this solution works.

Spacellary commented 1 year ago

For everyone using Termux it should be fixed now, can you guys try to update or reinstall and run again?

Update:

./rvx-builder.sh update && ./rvx-builder.sh run


Don't forget to backup your revanced.keystore if you plan on installing over your previous version.

Reinstall:

./rvx-builder.sh reinstall && ./rvx-builder.sh run


Additional troubleshooting here.

Spacellary commented 1 year ago

@nobl55 @Spoderman1997 Any changes/updates on the situation for you guys?

Spacellary commented 1 year ago

Should be fixed now with version 3.8.0.