inotia00 / rvx-builder

A NodeJS ReVanced Extended builder
GNU General Public License v3.0
525 stars 48 forks source link

bug: Not removed revanced-cache #88

Closed ghost closed 1 year ago

ghost commented 1 year ago

Type

Other

Application

YouTube_Music_5.55.53_arm64-v8a

Bug description

After changing the file, the revanced-cache folder and its contents are not deleted.

Steps to reproduce

No

Relevant log output

No

Screenshots or videos

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

inotia00 commented 1 year ago

At least you should write down which method you patched with

ghost commented 1 year ago

At least you should write down which method you patched with

I first patched YouTube music, the folder was not deleted. After that, I flashed YouTube_18.16.39 and the story repeated itself, the revanced-cache folder and its contents are not deleted when the folder is completed or the button is pressed. What is not clear here?

inotia00 commented 1 year ago

What tools did you use?

Is it CLI? or is it rvx-builder ? or is it Revancify?

Please describe in detail the environment and issues you have tried to patch with screenshots.

ghost commented 1 year ago

What tools did you use?

Is it CLI? or is it rvx-builder ? or is it Revancify?

Please describe in detail the environment and issues you have tried to patch with screenshots.

I launched the program, it asked me to update the program itself to version rvx-builder v3.9.2, I updated the . After that, all patches were updated. (I deleted all the old patches). Next, I already had YouTube and YouTubeMusik files uploaded that I wanted to patch. Through (Upload APK) I chose YouTubeMusik, clicked to patch, everything was successfully flashed. But on completion of the file patch, it always deleted the folder ( revanced-cache ) . Now this folder remains completely with all the files in this folder and it has to be deleted by hand.

https://user-images.githubusercontent.com/65110869/236212160-62f55f7e-fcc3-4656-91dc-f5fb452ec6c4.mp4

I think this will make it clearer.

inotia00 commented 1 year ago

tool used : rvx-builder 3.9.2

environment : Windows

content of the issue : The patch proceeds normally, but the revanced-cache directory is not removed

inotia00 commented 1 year ago

This is a temporary workaround to fix this old issue https://github.com/inotia00/rvx-builder/issues/7

The revanced-cache directory will be automatically removed each time you start the next patch

but after patching, a new revanced-cache directory will be created.

If this bothers you, simply use an older build of rvx-builder https://github.com/inotia00/rvx-builder/releases/tag/v3.9.1