inotify-tools / inotify-tools

inotify-tools is a C library and a set of command-line programs providing a simple interface to inotify.
GNU General Public License v2.0
3.19k stars 395 forks source link

Unit tests and integration tests fail on FreeBSD #108

Open yurivict opened 4 years ago

yurivict commented 4 years ago

Unit tests:

void event_to_str(): test end
void event_to_str_sep(): test begin
void event_to_str_sep(): test end
void str_to_event(): test begin
void str_to_event(): test end
void str_to_event_sep(): test begin
void str_to_event_sep(): test end
void basic_watch_info(): test begin
Failed to remove watch on /: Unknown error: -1
test.c:183 Test 'void basic_watch_info()' failed: Verification failed (inotifytools_remove_watch_by_filename("/"))
inotifytools_error() returns -1 (Unknown error: -1)
void watch_limit(): test begin
void watch_limit(): Warning, this test may take a while
Failed to remove watch on /tmp/inotifytools_test/0: Unknown error: -1
test.c:295 Test 'void watch_limit()' failed: Verification failed (inotifytools_remove_watch_by_filename(fn))
inotifytools_error() returns -1 (Unknown error: -1)
void tst_inotifytools_snprintf(): test begin
void tst_inotifytools_snprintf(): test end
Out of 80064 tests, 80062 succeeded and 2 failed.

Integration tests:

gmake[1]: Entering directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-3.20.2/t'
rm -f -r test-results
gmake aggregate-results-and-cleanup
gmake[2]: Entering directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-3.20.2/t'
*** inotifywait-daemon-logs-to-relative-paths.t ***
not ok 1 - event logged
#   
#       run_ &&
#       grep ATTRIB $logfile
#   
# failed 1 among 1 test(s)
yurivict commented 3 years ago

Tests still fail in the version 3.20.11.0.

ericcurtin commented 3 years ago

Pull requests welcome!

github-actions[bot] commented 1 year ago

We are clearing up our old issues and your ticket has been open for 2 years with no activity. Remove stale label or comment or this will be closed in 30 days.

yurivict commented 1 year ago

Not stale.

ericcurtin commented 1 year ago

inotify-tools works well, I would be tempted to start a 4.x version in rust, would be cleaner

ericcurtin commented 1 year ago

I do apologise this hasn't been worked on, simply put there is nobody paid to work on inotify-tools, although I try my best to maintain in my free time, outside work hours. Which made me think recently, maybe there's a potential google summer of code project here.

yurivict commented 1 year ago

Now in 4.23.8.0 the failure looks like this:

unit test
gmake[1]: Entering directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-4.23.8.0/libinotifytools/src'
gmake[1]: 'test' is up to date.
gmake[1]: Leaving directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-4.23.8.0/libinotifytools/src'
void event_to_str(): test begin
void event_to_str(): test end
void event_to_str_sep(): test begin
void event_to_str_sep(): test end
void str_to_event(): test begin
void str_to_event(): test end
void str_to_event_sep(): test begin
void str_to_event_sep(): test end
void basic_watch_info(): test begin
void basic_watch_info(): test end
void watch_limit(): test begin
void watch_limit(): Warning, this test may take a while
void watch_limit(): test end
void tst_inotifytools_snprintf(): test begin
void tst_inotifytools_snprintf(): test end
Out of 480076 tests, 480076 succeeded and 0 failed.
integration test
gmake[1]: Entering directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-4.23.8.0/t'
rm -f -r test-results
gmake aggregate-results-and-cleanup
gmake[2]: Entering directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-4.23.8.0/t'
*** fsnotifywait-subtree.t ***
ok 1 - event logged
# passed all 1 test(s)
1..1
*** inotifywait-csv-watched-dir.t ***
not ok 1 - event logged
#   
#       run_and_check_log inotifywait
#   
# failed 1 among 1 test(s)
1..1
gmake[2]: *** [Makefile:38: inotifywait-csv-watched-dir.t] Error 1
gmake[2]: Leaving directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-4.23.8.0/t'
gmake[1]: *** [Makefile:31: test] Error 2
gmake[1]: Leaving directory '/usr/ports/sysutils/inotify-tools/work/inotify-tools-4.23.8.0/t'
*** Error code 2

Stop.

FreeBSD 13.2