inovex / elements

Lovingly crafted ui components based on web components. Works well with all Frameworks - including Angular, React and Vue.
https://elements.inovex.de
MIT License
69 stars 9 forks source link

refactor: optimize clean up script for outputs and node_modules #1321

Closed BenPag closed 6 months ago

BenPag commented 6 months ago

Closes #1091

Proposed Changes

BenPag commented 6 months ago

I noticed two things when running the scripts:

  • packages/elements/.stencil & .nx still exist
  • the clean script seems not to work quite right, I get the error below
$ nx run-many --target=clean && nx reset && shx rm -rf node_modules

  ✔  nx run elements-angular:clean (816ms)
  ✔  nx run elements-react:clean (821ms)
  ✔  nx run elements:clean (832ms)

  ✔  nx run elements-vue:clean (698ms)
  ✔  nx run ui-patterns:clean (703ms)
  ✔  nx run elements-angular-example:clean (695ms)

  ✔  nx run elements-react-example:clean (693ms)

  ✔  nx run elements-vue-example:clean (708ms)

  ✔  nx run ui-patterns-playground:clean (968ms)

————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————
  ✖  nx run storybook:clean
     NX   Daemon process terminated and closed the connection

    Please rerun the command, which will restart the daemon.
    If you get this error again, check for any errors in the daemon process logs found in: /Users/arbeit/Projects/elements/.nx/cache/d/daemon.log

    Warning: command "nx run storybook:clean:dist" exited with non-zero status code

  ✔  nx run landingpage:clean (905ms)
  ✔  nx run workspace:clean (723ms)

————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 NX   Ran target clean for 12 projects (3s)

  ✔    11/12 succeeded [0 read from cache]

  ✖    1/12 targets failed, including the following:
    - nx run storybook:clean

error Command failed with exit code 1.

I added the .stencil dir. Regarding your error I will investigate...