inovex / elements

Lovingly crafted ui components based on web components. Works well with all Frameworks - including Angular, React and Vue.
https://elements.inovex.de
MIT License
69 stars 9 forks source link

refactor(landingpage): reflect elements storybook version in URL #1380

Closed TobiasHeimGalindo closed 3 weeks ago

TobiasHeimGalindo commented 2 months ago

Closes #1338

Review Notes: I noticed that navigating to different Storybook elements was causing an extra reload. This didn't show up when serving the page locally. To fix this, I used useMemo in the useStorybookUrl hook to prevent unnecessary recalculations of the Storybook URL unless the search parameters change. However as seen in the video this issue still occurs.

https://github.com/inovex/elements/assets/81302108/b8bf6ed9-42fd-4838-b205-4bd59114cecf