search

inovex / elements

Lovingly crafted ui components based on web components. Works well with all Frameworks - including Angular, React and Vue.
https://elements.inovex.de
MIT License
69 stars 9 forks source link

elements-angular: Cannot find InoElementsModule #72

Closed janivo closed 3 years ago

janivo commented 3 years ago

Describe the bug

Cannot find InoElementsModule in @inovex.de/elements-angular/. Before the release of version 1.0.0, it was possible to import the Elements Module with import { InoElementsModule } from '@inovex.de/elements-angular';. With the current version, you have to import it with @inovex.de/elements-angular/src/ino-elements.module which leads to other typescript errors.

To Reproduce

Steps to reproduce the behavior:

  1. Clone the elements-example-angular project
  2. Update the inovex elements dependency to @inovex.de/elements-angluar with version being 1.0.0
  3. Change the appearances of @inovex... to @inovex.de....
  4. ng serve
  5. See compile error

Expected behavior

Should compile without any problems.

Your Environment

| Software | Version | | -------- | ------- | | @inovex.de/elements | 1.0.0 |
janivo commented 3 years ago

The issue is probably that the dist/ folder inside the angular package was ignored. Due to a pipeline error I published the packages manually with the following command: npm publish --access=public. During the publishing process, the npm publish command looks for any .npmignore' files to exclude files from building that are listed there. If this file does not exist, the.gitignore' file is taken (source: npmc docs). In this case the folder dist/ is listed there, which is why the folder dist was excluded from the build.

The solution is to create an additional .npmignore file without the dist/ folder being listed there. The error did not occur in earlier versions due to other publishing mechanisms we have used.

P1NHE4D commented 3 years ago

It looks like it's working now

janivo commented 3 years ago

Yes, I released Version 1.0.1 so the dist files are correct now. But it still requires to release each package by hand. I want to find a way that automates the release process with a script.

janivo commented 3 years ago

I described the problem in https://github.com/inovex/elements/issues/110 and will close this issue for now