search

inovex / prometheus-libvirt-exporter

prometheus-libvirt-exporter
MIT License
21 stars 6 forks source link

grafana board + awesome alerts #17

Open cervajs opened 8 months ago

cervajs commented 8 months ago

i have plan publish (if not exist) grafana board and awesome alerts to https://samber.github.io/awesome-prometheus-alerts/

can you share what you have for this exporter now? thanks

frittentheke commented 8 months ago

Hey @cervajs, thanks for the interest in this exporter and to gather some dashboards / alerts! We do have some basic dashboards that we could share in theory. But they would not mixins, but actual JSON exported dashboards then. I'd rather first convert the dashboards (and alerts if they can be generalized) to Grafonnet (https://grafana.github.io/grafonnet/) and then distribute and lifecycle it with the exporter.

Kinda like it's done / attempted for the node-exporter at https://github.com/prometheus/node_exporter/tree/master/docs/node-mixin

Or what are your thoughts on the matter?

weshouman commented 7 months ago

I have ported the original libvirt-dashboard to work with this implementation, alongside with some parameterization for the job and host names at https://grafana.com/grafana/dashboards/20737-libvirt-dashboard/

frittentheke commented 7 months ago

@weshouman thanks a lot for your time and work! Would you maybe create a PR to add your dashboard to this repo?

We already discussed adding a dashboard (and maybe even alerts), but would like to move to something along the lines of https://github.com/grafana/grafonnet to have this as mixins which can be kept up to date with Grafana updates and also contains at least some tests to verify things still work.

frittentheke commented 5 months ago

@weshouman May I kindly ask again if you would push your dashboard as a PR to this project?

weshouman commented 5 months ago

Been busy recently, if I didn't manage to commit it through the month feel free to commit it directly

Message ID: <inovex/prometheus-libvirt-exporter/issues/17/2112826393@ github.com>

frittentheke commented 5 months ago

Been busy recently, if I didn't manage to commit it through the month feel free to commit it directly … Message ID: <inovex/prometheus-libvirt-exporter/issues/17/2112826393@ github.com>

No worries. I just refrained from taking things without permission. A PR is somewhat of a clear sign you are OK to contribute this.