inovex / scrumlr.io

Webapp for collaborative online retrospectives
https://scrumlr.io
MIT License
241 stars 46 forks source link

Upload CSV/JSON #4197

Open SelinaBuff opened 3 weeks ago

SelinaBuff commented 3 weeks ago

User Stories

  1. Upload exported boards
  1. Upload during template selection

Image

  1. Two upload methods
  1. Clear upload instructions
    • As a user, I expect clear instructions for uploading files:
  • Title: "Import CSV/JSON" or in German: "CSV/JSON importieren"
  • Description: "Upload file or drag here" or in German: "Datei hochladen oder hierher ziehen"
  1. Automatic template selection
brandstetterm commented 1 week ago

Some information that is important for implementation is missing here. For example, what happens if cards from other users are (also) imported, even tho they are not participants of the new session?

Schwehn42 commented 1 week ago

or example, what happens if cards from other users are (also) imported, even tho they are not participants of the new session

or in that regard, if the user doesn't exist at all 👀
I think the JSON should be able to reference the author(s) by id and name. So the import flow could look like this:

  1. author has id ref in JSON:
    1. user exists in DB: use determined name/avatar
    2. user doesn't exist: throw error OR use default OR go to step 2
  2. If author has name field, use that (plus default avatar or randomly generated)
  3. otherwise use some kind of default, maybe "Unknown Author" with a default/ghost avatar
brandstetterm commented 1 week ago

In my opinion, using the original authors for the imported cards is kinda a no-go, since it's not guaranteed that the users know of the new session. Me as a user wouldn't be that happy about my cards (with me as an author) being using on a board I don't know of.

Schwehn42 commented 1 week ago

But that defeats at least a main point of the import then, doesn't it? I want to be able to import a board and still be able to edit my own cards / reactions / filter by user if I'm in the session. Treating every note like it's from someone else would'nt allow this.

Regarding your point I think there are other ways to verify the integrity of the board. For example an imported note could be marked as such (with a very small icon or something along those lines) which would verify if the note was just written by the author or if it was imported.

brandstetterm commented 1 week ago

These are my main concerns right now:

Also, if you're going to import a board, you are automatically the owner of the resulting session. As an owner of a session, you can edit all of the cards.

I think my preferred solution for that would be the following: If I import a board, my cards will still have me as an author, but the cards from everyone else won't have an author anymore (author = null). Instead, these author-less cards could be showing our skeleton author (Stan) for example.

Schwehn42 commented 1 week ago

I don't see a reason why this cannot/shouldn't be done for registered users. For anonymous accounts sure, but there is no technical limitation which would disallow just adding the verified accounts to a board that comes to my mind. You could even add an privacy option that could disallow this behaviour (make it default if you want) and would lead to what you suggested instead.

However, if you're concerned about security concers this only begs the question why owners are allowed to edit everyone's notes. Deleting them, sure, but I honestly can't comprehend why this is allowed 😅

brandstetterm commented 1 week ago

I share your opinion, we should question why owners are able to edit all notes.

Still, I as a user don't want to be automatically added to the participants of a session. I want to get asked at least if I wanna join.

Schwehn42 commented 1 week ago

I think the easiest solution for this is a setting that allows whether your account may be used in other sessions or as an export. This does not only concern exports/imports, by the way – there might be a future option to duplicate sessions in the templates/sessions section, where the same issue would occur.

Combined with the other suggestion of marking imported notes I believe this ticks all the boxes regarding privacy, integrity, and still being a viable feature.

We should definitely discuss this within the team though, as it obviously isn't a trivial topic 😄

Schwehn42 commented 1 week ago

or actually just f it, we can just keep the names, as soon as the session feature is ready the import/export is probably only used for archiving anyways 🤷‍♂️

mateo-ivc commented 1 week ago

I think it's still a useful feature, especially for anonymous users who don't want to create an account.

SelinaBuff commented 5 days ago

I spoke to our data protection officer and he said that it is completely sufficient if we mark the edited notes. What we could or should do is just give the moderator the rights to edit notes.

Image