search

inovex / scrumlr.io

Webapp for collaborative online retrospectives
https://scrumlr.io
MIT License
262 stars 58 forks source link

fix: scss warnings #4486

Closed Schwehn42 closed 1 month ago

Schwehn42 commented 2 months ago

Description

Recently, the following warnings came up:

<w> 
<w> src/constants/colors.scss 235:11                                             set-base-colors()
<w> src/constants/colors.scss 255:3                                              @import
<w> src/constants/style.scss 4:9                                                 @import
<w> src/components/BoardHeader/HeaderMenu/BoardOptions/BoardOptionLink.scss 1:9  root stylesheet
<w> 
<w> You probably don't mean to use the color value gray in interpolation here.
<w> It may end up represented as gray, which will likely produce invalid CSS.
<w> Always quote color names when using them as strings or map keys (for example, "gray").
<w> If you really want to use the color value here, use '"" + $color-name'.

So I did as suggested and put the map keys "gray" and "navy" as quotes, which should hopefully fix it.

Also, another warning concerning rule order was fixed: https://sass-lang.com/d/mixed-decls

Changelog

github-actions[bot] commented 2 months ago

The deployment to the dev cluster was successful. You can find the deployment here: https://4486.development.scrumlr.fra.ics.inovex.io This deployment is only for testing purposes and will be deleted after 1 week. To redeploy rerun the workflow. DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images - ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-1251b15 - ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-1251b15