inovexcorp / mobi

Mobi is a decentralized, federated, and distributed graph data platform for teams and communities to publish and discover data, data models, and analytics that are instantly consumable.
https://mobi.inovexcorp.com
GNU Affero General Public License v3.0
45 stars 11 forks source link

Language specific characters are not correct when uploading ontology #11

Closed gregid closed 4 years ago

gregid commented 5 years ago

Try adding new ontology by uploading doap.rdf from: https://github.com/ewilderj/doap/tree/master/schema e.g. portuguese description: Vocabulário de descrição de um Projeto becomes Vocabulário de descrição de um Projeto

Adding special characters manually in mobi works fine, so the problem with encoding is only with the upload.

gregid commented 4 years ago

I have just been checking the new version of mobi but the problem persists - the uploaded files seem to be losing their encoding. I am not sure about other OSs but it is definitely a problem on Windows.

mnmercer commented 4 years ago

Hello @gregid . I believe your issue is coming from outside of Mobi and is an issue with the encoding of the file on your Windows machine. On my Mac, I went to the repository you linked, opened up the raw view of the file you mentioned, copied the content into my developer text editor (Visual Studio Code), saved it, then uploaded the file into Mobi and the special characters are displaying fine.

Screen Shot 2019-10-07 at 2 16 36 PM

How did you save the file onto your Windows machine?

gregid commented 4 years ago

I thought this may be an OS related issue since no one else noticed it. Previously I had the repo cloned, this time I repeated exactly your steps (raw -> copy/paste -> save in VS code) the encoding is also UTF-8 which should be fine. Here is a screenshot:

mobi-lost-encoding

skahmann commented 4 years ago

Hi @gregid I am also trying to recreate the problem you are seeing. I am using the latest version of the 1.16 release (link). I uploaded this file to the ontology editor:

doap.rdf.zip

and I'm seeing the correct rendering of characters:

image

gregid commented 4 years ago

Hi @skahmann - which operating system have you used for this test? I will try to test it again with the latest version (on Windows)

skahmann commented 4 years ago

I am using macOS Catalina 10.15.4.

gregid commented 4 years ago

This problem was only Windows specific - I will let you know if it persists with latest version.

skahmann commented 4 years ago

Sounds good. I can test on Windows as well, but I probably don't have the same locale settings you are using which may affect the results.

skahmann commented 4 years ago

Ah, I was able to recreate this on a test Windows machine. I'll see if I can find the problem...

gregid commented 4 years ago

Unfortunately the problem persists on 1.16.65. Edit: yep the same here

skahmann commented 4 years ago

Apologies for the delay on this issue. We've got all the info we need to reproduce the problem and we've got a bug filed to be included in the next release. I'll update this ticket when the fix is available.

gregid commented 4 years ago

Great to hear! Thank you.

gregid commented 4 years ago

I have just checked the 1.17.75 version and it now works as expected.