inovua / reactdatagrid

Empower Your Data with the best React Data Grid there is
https://reactdatagrid.io
Other
3.44k stars 57 forks source link

The recent clipboard feature broke the default browser right click context menu on any cell of the grid #249

Closed yurigenin closed 2 years ago

yurigenin commented 2 years ago

This commit below broke the default browser menu on right clicking on any cell of the grid even if the clipboard feature is disabled. You can try the documentation for the clipboard property (default is false) and try to right click on any cell. No browser menu comes up.

https://github.com/inovua/reactdatagrid/commit/001f8d37899800025ab8434fbb855b76ea6d90e1

The issue is that the clipboard plugin add this property:

https://github.com/inovua/reactdatagrid/blob/master/enterprise-edition/plugins/clipboard/index.ts#L16

image

This line below used to be falsy and the code exited:

https://github.com/inovua/reactdatagrid/blob/master/community-edition/plugins/menus/useMenus/index.ts#L219

image

Instead, now the flow proceeds to this line below which causes the right hand menu default action to be swallowed if even the clipboard is disabled:

https://github.com/inovua/reactdatagrid/blob/master/community-edition/plugins/menus/useMenus/index.ts#L227

image
inovua-admin commented 2 years ago

Fixed in v4.14.1