inovua / reactdatagrid

Empower Your Data with the best React Data Grid there is
https://reactdatagrid.io
Other
3.44k stars 57 forks source link

At rtl direction when we have more then 14 columns - not displayed all cells data #28

Open art1990 opened 3 years ago

art1990 commented 3 years ago

What you did: implemented a grid in rtl mode What happened: when we have more then 14 columns - not displayed all cells data Screenshot from 2021-01-26 22-20-11 Screenshot from 2021-01-26 22-20-22

inovua-admin commented 3 years ago

Thanks for reporting - I'm sure it has to do with https://reactdatagrid.io/docs/api-reference#props-virtualizeColumnsThreshold So until we come up with a fix, you can increment that number if you have say 20 cols, so they are rendered at all times.

art1990 commented 3 years ago

thanks, this resolved my problem

inovua-admin commented 3 years ago

Glad it fixes your issue. We'll keep this opened as it is a bug, and the above solution is just a workaround. When there are very many columns and you have rtl, you can't just make the threshold very big, since it will degrade the grid performance too much - so column virtualization is needed.

art1990 commented 3 years ago

i found another bug in rtl direction if we have more then 14 columns and columns props doesnot have props flex, screenshot bellow

Снимок экрана 2021-02-08 в 08 27 40

if we added flex param to last columns it looks like good, but when we accept sort to columns (or filtering) table body is shifted and aligns when scrolling

https://user-images.githubusercontent.com/46848114/107184318-02311680-69e9-11eb-930c-1557ba7013c7.mov

inovua-admin commented 3 years ago

thanks for the report. one thing in the video above is the country name is used for many cols - it can be reused, but in this case make sure each column has a unique id property. Probably this is not the cause of the issue, but it's a good practice to follow.

Mohammad-Mohimmatech commented 2 years ago

Hello @inovua-admin, firstly I would like to thank you very much for this great library!

Are there any updates on solving this bug? It would be greatly appreciated as we have some rather large datasets.

Thanks!

adnanmirani1990 commented 1 year ago

To solve the issue change the CSS style for the .inovua-react-virtual-list__view-container class, like this: .inovua-react-virtual-list__view-container { overflow: hidden !important }