Closed mrustl closed 3 years ago
Fix config: min and max value in config$treatment$processes should be parsed as numbers already since https://github.com/inowas/frontend-app/releases/tag/v1.8.2
For old models, you might need to reenter the values, though!
Content of attached dataset (input:
qmra_config_veronika.json
, r-script:qmra_improvements.Rmd
, output: renderedqmra_improvements.Rmd
tohtml
,docx
,pdf
): qmra_improvements.zipBelow the rendered content of the
qmra_improvements.Rmd
as markdown, includingto-dos
for @Roschl:General improvement for
UI inflow
Remove
triangle
distribution (does not make sense here!)Debugging Veronika`s Config
Load config
Try risk calculation
Check treatment train
Identified Problems:
TreatmentSchemeName
defined in UI (SMARTplus for campy
) is not copied for all processes. To be fixed by @RoschlCheck treatment steps
Identified Problems:
min
/max
are interpreted as "character" instead of "numeric" (@Roschl: please fix this in the UI)log_*
distributions do not make sense for fortreatment steps
as the input data is already provided as log10 reduction. Alsotriangle
is not useful as no input datamode
is provided. Suggestion: simpify by only providinguniform
and may be alsonorm
distribution (for the latter kwb.qmra assumes values for the missing inputsmean
andsdev
, see: https://kwb-r.github.io/kwb.qmra/reference/create_random_distribution.html)Fix config
By manually converting
min
andmax
to numeric (@Roschl: please fix this in the UI by providingnumeric
instead ofcharacter
)Re-run calculation
R simulation now works:
Risk Output
total
This table can get quite large (dependent on number of pathogens, treatment schemes, monte carlo runs) thus only
TreatmentSchemeID
andPathogenID
are provided asinteger
(less data demand).If names are needed for plotting these can be integrated in the UI by using the content of the following configurations:
Inflow (
config$inflow
) by joiningTreatmentSchemeID
in order to add columnTreatmentSchemeName
Treatment schemes (
config$treatment$schemes
), (see Check treatment train) by joiningPathogenID
in order to add columnsPathogenName
andPathogenGroup
@Roschl: could you add the names to the CSV / JSON files for download in the UI using the available data described above?
Session info