inpho / inphosite

The InPhO API
https://inphoproject.org
15 stars 5 forks source link

Search box should keep focus #119

Closed colinallen closed 11 years ago

colinallen commented 11 years ago

When entering text into search box, if you select an item in the drop down using the mouse (instead of enter key), the text appears in the box but the box loses focus. To get anything to happen you have to click back in the box and hit enter.

JaimieMurdock commented 11 years ago

Search box behavior has been modified on http://inphodev.cogs.indiana.edu:8088/ but new bootstrap CSS changed margins and such - need to make a pass to fix styling.

colinallen commented 11 years ago

Getting there! Two issues: (1) Suppose I just want to search for "Kant's Philosophy" -- I don't think I can do it. If I type that phrase, two options appear, and any action I take will force me to go directly to one of the two pages, rather than to the disambiguation page. However, there are cases where I might want to go to the disambiguation page because that provides additional information about the entity that's not in the drop down list, such as whether it's a journal title or an idea. (2) The drop down seems slower to appear than previously. But I don't have anything but subjective assessment to back that up.

JaimieMurdock commented 11 years ago

1) I think I have corrected this behavior. with the first element highlighted, it auto goes to that element. I disabled the first element highlighting, so you have to use the arrows to go through the autoselect. We can also add icons for the entity types, but it may be cluttered.

2) The speed is equivilent between inpho and inphodev. I think it's just the nature of how it's retrieving the results. Typeahead.js may be an alternative w/results caching, but no guarantee of speedup: https://github.com/twitter/typeahead.js

colinallen commented 11 years ago

1) I think I have corrected this behavior. with the first element highlighted, it auto goes to that element. I disabled the first element highlighting, so you have to use the arrows to go through the autoselect. We can also add icons for the entity types, but it may be cluttered.

I think this solution is appropriate if implemented, but I'm not seeing it behave that way on either Safari/Chrome or Firefox. First item still automatically highlighted.

2) The speed is equivilent between inpho and inphodev. I think it's just the nature of how it's retrieving the results. Typeahead.js may be an alternative w/results caching, but no guarantee of speedup: https://github.com/twitter/typeahead.js

It's ok as is at the moment.

JaimieMurdock commented 11 years ago

Try it on http://inphodev.cogs.indiana.edu:8088/, did not deploy. Will remember to mention server in future comments.

On 06/10/2013 10:55 PM, colinallen wrote:

1) I think I have corrected this behavior. with the first element highlighted, it auto goes to that element. I disabled the first element highlighting, so you have to use the arrows to go through the autoselect. We can also add icons for the entity types, but it may be cluttered.

I think this solution is appropriate if implemented, but I'm not seeing it behave that way on either Safari/Chrome or Firefox. First item still automatically highlighted.

2) The speed is equivilent between inpho and inphodev. I think it's just the nature of how it's retrieving the results. Typeahead.js may be an alternative w/results caching, but no guarantee of speedup: https://github.com/twitter/typeahead.js

It's ok as is at the moment.

— Reply to this email directly or view it on GitHub https://github.com/inpho/inphosite/issues/119#issuecomment-19238203.

colinallen commented 11 years ago

yep - works there!

Thanks.

On Jun 11, 2013, at 12:54 AM, Jaimie Murdock notifications@github.com wrote:

Try it on http://inphodev.cogs.indiana.edu:8088/, did not deploy. Will remember to mention server in future comments.

On 06/10/2013 10:55 PM, colinallen wrote:

1) I think I have corrected this behavior. with the first element highlighted, it auto goes to that element. I disabled the first element highlighting, so you have to use the arrows to go through the autoselect. We can also add icons for the entity types, but it may be cluttered.

I think this solution is appropriate if implemented, but I'm not seeing it behave that way on either Safari/Chrome or Firefox. First item still automatically highlighted.

2) The speed is equivilent between inpho and inphodev. I think it's just the nature of how it's retrieving the results. Typeahead.js may be an alternative w/results caching, but no guarantee of speedup: https://github.com/twitter/typeahead.js

It's ok as is at the moment.

— Reply to this email directly or view it on GitHub https://github.com/inpho/inphosite/issues/119#issuecomment-19238203.

— Reply to this email directly or view it on GitHub.

JaimieMurdock commented 11 years ago

Uploaded to https://inpho.cogs.indiana.edu/