search

inpho / inphosite

The InPhO API
https://inphoproject.org
15 stars 5 forks source link

bad issn (not) #80

Closed colinallen closed 11 years ago

colinallen commented 11 years ago

Journals whose ISSN contains the letter X, e.g. https://inpho.cogs.indiana.edu/journal/4221 are getting marked as having bad ISSN when in fact it's correct. I think that only the last character is only ever a numeral or X as it's a checksum value of 10 -- see http://en.wikipedia.org/wiki/International_Standard_Serial_Number

alefrost commented 11 years ago

I the option for the ISSN to end in an 'X' and that took the list from 90 down to 9. http://inphodev.cogs.indiana.edu:8087/journal/4221 is still on the list and ends in 'X', but I feel like that might be a different issue with the ISSN that I am not catching.

colinallen commented 11 years ago

Thanks Alex -- There was a leading space that I deleted manually. Suggests though that we should trim leading and following whitespace when inserting items into the database. - Colin