search

inpho / inphosite

The InPhO API
https://inphoproject.org
15 stars 5 forks source link

label changes not sticking #97

Closed colinallen closed 11 years ago

colinallen commented 11 years ago

When I change the label of 'philosophy of sex' to 'sex', the button goes green, but a quick search and return to the page reveals that nothing was changed in the database.

JaimieMurdock commented 11 years ago

I have a fix for this, but there is a larger design decision as to why the labels were not sticking.

All of the statistics are based off the search patterns, whcih include the label. Additionally the label is a canonical reference for the database. By changing the label we change the thing-ness of the object. I think we should allow for changes, since the stats are really run off the search patterns listed below, but for most things it is identified by the label.

colinallen commented 11 years ago

Perhaps we want to be cautious about changing labels, but we have a several that ought to be changed, namely the 'philosophy of' ones that are not in the seed ontology.

Regarding the statistics, two questions: 1. Won't they just rerun with the new labels the following morning? 2. Don't 'philosophy of ' prefixes get stripped anyway?

JaimieMurdock commented 11 years ago

Closed this bug by adding label to the allowed update parameters. Deployed.