search

inpho / vsm

Vector Space Model Framework developed for InPhO
http://inpho.github.io/vsm
Other
35 stars 14 forks source link

Random seeds in LdaCgsMulti #102

Closed JaimieMurdock closed 9 years ago

JaimieMurdock commented 9 years ago

LdaCgsMulti.train() takes a seeds argument which expects either None or a list of seeds. If None, it broadcasts this to all threads. Should we also have this broadcast single seeds? Does this create threading issues?

rrose1 commented 9 years ago

By broadcasting single seeds, do you mean copying the same seed to every thread?

train deconstructs the seed objects completely and sends the Mersenne Twister state descriptions contained therein as basic c-types. The behavior I'm supposing you mean could be accomplished by passing a list of references to the same seed. (For example, make a seed, wrap it in a list and multiply the list by the number of processors.)

JaimieMurdock commented 9 years ago

Issue incoherent¸ intent replaced by #107