Many unit tests no longer valid - Githubissues

inpho / vsm

Vector Space Model Framework developed for InPhO

http://inpho.github.io/vsm

Other

35 stars 14 forks source link

Many unit tests no longer valid #88

Closed rrose1 closed 9 years ago

rrose1 commented 9 years ago

The unit tests were not updated along with recent code changes.

JaimieMurdock commented 9 years ago

See issue #86 for some useful vsm.spatial tests.

Once unittests are done, we can finish travis-ci integration.

JaimieMurdock commented 9 years ago

I've started revising these in the tests branch.

[x] tests_beaglecomposite
[x] tests_beaglecontext
[x] tests_beagleenvironment
[x] tests_beagleorder
[x] tests_beagleviewer
[x] tests_core -> tests_structarr, tests_split
[x] tests_corpus
[x] tests_corpus_util
[x] tests_corpusbuilders
[x] tests_labeleddata
[x] tests_ldagibbs
[x] tests_ldagibbsviewer
[x] tests_linalg -> tests_spatial
[x] tests_lsa
[x] tests_lsaviewer
[x] tests_model
[x] tests_similarity
[x] tests_simwalks
[x] tests_tfidf
[x] tests_tfidfviewer
[x] tests_tf
[x] tests_tfviewer

JaimieMurdock commented 9 years ago

tests_beaglecomposite

Traceback (most recent call last):
  File "/home/jammurdo/workspace/vsm/unit_tests/tests_beaglecomposite.py", line 27, in setUp
    self.m = BeagleComposite(self.cc, self.cm.matrix, self.ec, self.om.matrix)
  File "/home/jammurdo/workspace/vsm/vsm/model/beaglecomposite.py", line 41, in __init__
    self.ctx_matrix /= np.sqrt((ctx_matrix * ctx_matrix).sum(1)[:,np.newaxis])
AttributeError: 'BeagleComposite' object has no attribute 'ctx_matrix'

JaimieMurdock commented 9 years ago

Previous tests for vsm.extensions.corpusbuilders.corpusbuilders.dir_tokenize and coll_tokenize both break on sentence context_types. The issue here may be introduced by better parsing of blank lines.

JaimieMurdock commented 9 years ago

LdaCgsViewer is missing simmat_words TfViewer is missing simmat_words

rrose1 commented 9 years ago

LdaCgsViewer should never have had a simmat_words.

JaimieMurdock commented 9 years ago

The old multiprocessing implementations appear to be throwing errors:

[ ] BeagleContextMulti
[ ] TfIdfMulti
[ ] TfMulti

JaimieMurdock commented 9 years ago

test_spatial.py linalg.row_normalize,linalg.row_cos_mat, and linalg.hstack_coo no longer exist .

JaimieMurdock commented 9 years ago

I believe we finished migrating these.

colinallen commented 9 years ago

Just checked and all seems good.

On Feb 2, 2015, at 12:00 PM, Jaimie Murdock notifications@github.com wrote:

I believe we finished migrating these.

— Reply to this email directly or view it on GitHub https://github.com/inpho/vsm/issues/88#issuecomment-72493437.