inpsyde / WP-Stash

Bridge between WordPress and StashPHP, providing a PSR6-compliant caching system for WordPress
https://inpsyde.com/en/wordpress-caching-system-wpstash/
GNU General Public License v2.0
51 stars 12 forks source link

Add new env variable WP_STASH_RUNNABLE #17

Closed brianvarskonst closed 4 years ago

brianvarskonst commented 4 years ago

The purpose of this PR is to disable WP Stash with a env variable temporarily, so there is no need to remove this mu plugin.

Add new env variable WP_STASH_RUNNABLE & WpStash Class constants

Biont commented 4 years ago

Is there anything wrong with doing it the way that was described in #16? Doing the bypass in object-cache.php sound easier than adding extra logic

brianvarskonst commented 4 years ago

Is there anything wrong with doing it the way that was described in #16? Doing the bypass in object-cache.php sound easier than adding extra logic

Sorry, I don't read this, because I was not thinking someone other also want to do something like this. 😄

Thanks, for the mention, I will to rewrite this as suggested.

dnaber-de commented 4 years ago

I agree with Moritz that it is too much logic to actually completely bypass WPStash. However, I feel sorry that I didn't promote this issue better within the team.

Biont commented 4 years ago

ce6811ee69c5c5310be908a81016296e84a258d2