inpsyde / WP-Stash

Bridge between WordPress and StashPHP, providing a PSR6-compliant caching system for WordPress
https://inpsyde.com/en/wordpress-caching-system-wpstash/
GNU General Public License v2.0
51 stars 12 forks source link

Support wp_cache_get_multiple #18

Closed bueltge closed 4 years ago

bueltge commented 4 years ago

Available since WP 5.5, see https://make.wordpress.org/core/2020/08/11/introduce-wp_cache_get_multiple/

Biont commented 4 years ago

We can implement this, but it needs to be stated that won't make a practical difference: WP Core provides a fallback shim that simply wraps multiple wp_cache_get calls. And guess what: Stash does the same thing!

It is still a good idea to support this so that we are forward compatible in the event that Stash adds support for this, but I don't see that happening soon. I could not even find an open issue for this apart from this seven-year old issue

bueltge commented 4 years ago

So we should leave it for now, maybe StashPHP will support it later, and then is the effort helpful.

Biont commented 4 years ago

It doesn't take much effort to do it now and allowed me to do some welcome house cleaning

bueltge commented 4 years ago

So feel free to do them. However, I understand that the benefit of this function is less. But housekeeping is more helpful. ;)