inpsyde / WP-Stash

Bridge between WordPress and StashPHP, providing a PSR6-compliant caching system for WordPress
https://inpsyde.com/en/wordpress-caching-system-wpstash/
GNU General Public License v2.0
51 stars 12 forks source link

Fix get multiple method #27

Closed shvlv closed 1 year ago

shvlv commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix.

What is the current behavior? (You can also link to an open issue here) The current wp_cache_get_multiple and \Inpsyde\WpStash\ObjectCacheProxy::get_multiple don't work as expected. The problem is when we add the item to the cache we generate an item key with \Inpsyde\WpStash\Generator\KeyGen but we completely ignore this when retrieving multiple values. So the cache is always missing.

What is the new behavior (if this is a feature change)? The current fix allows us to retrieve multiple values which were added before.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No.

Other information: Unrelated but with 6.0.0 we have wp_cache_set_multiple. It should be included in the library as well.