inpsyde / WP-Stash

Bridge between WordPress and StashPHP, providing a PSR6-compliant caching system for WordPress
https://inpsyde.com/en/wordpress-caching-system-wpstash/
GNU General Public License v2.0
51 stars 12 forks source link

[Feature Request]: Implement new core caching api functions. #28

Closed spacedmonkey closed 1 year ago

spacedmonkey commented 1 year ago

Is your feature request related to a problem?

There has been a number of improve to the caching api, including. Adding the following functions.

Describe the desired solution

Implement core functions.

Describe the alternatives that you have considered

N / A

Additional context

https://make.wordpress.org/core/2022/04/29/caching-improvements-in-wordpress-6-0/ https://make.wordpress.org/core/2022/10/11/performance-field-guide-for-wordpress-6-1/

Code of Conduct

Biont commented 1 year ago

Hello @spacedmonkey and thank you for raising this. This is definitely something worth picking up and we'll try to allocate some time soon.

It should be noted that the *_multiple are unlikely to yield any improvements, because the underlying StashPHP library itself only unwraps these calls back into single-item operations (See also #18 for reference)

There is still value in implementing them for future-proofing, though

spacedmonkey commented 1 year ago

Thanks @Biont

The biggest one of this list I would like to see implemented is wp_cache_supports. I am core committer and it is extremely useful to understand what feature your object cache supports. Specially group flush and multiple gets. We can't use these features in core unless we know they are supported.

See https://github.com/WordPress/performance/issues/718 for more context.

Biont commented 1 year ago

https://github.com/inpsyde/WP-Stash/releases/tag/v3.4.0 @spacedmonkey