Currently WPStash is listening in Inpsyde\WpStash\Config only to constants via defined(). In some scenarios this might not match because the configration happens via env vars. therefore there should be first of all a check in Inpsyde\WpStash::fromConfig() if the var is either defined or via getenv available and depending on that the config generated and also there's a duplication for generating the Config in Inpsyde\WpStash::fromConfig() and `Inpsyde\WpStash::getDriver().
Biont
commented
5 years ago
Currently WPStash is listening in
Inpsyde\WpStash\Configonly to constants viadefined(). In some scenarios this might not match because the configration happens via env vars. therefore there should be first of all a check inInpsyde\WpStash::fromConfig()if the var is eitherdefinedor viagetenvavailable and depending on that the config generated and also there's a duplication for generating the Config inInpsyde\WpStash::fromConfig()and`Inpsyde\WpStash::getDriver().