search

inpsyde / Wonolog

Monolog-based logging package for WordPress.
https://inpsyde.github.io/Wonolog/
MIT License
173 stars 17 forks source link

Let Action and Filter listeners know about the current hook explicitly #54

Closed widoz closed 3 years ago

widoz commented 4 years ago

fixes #41

gmazzap commented 4 years ago

Code looks fine to me, but LogActionSubscriber::update() still uses current_filter to determine log level.

If we go this path, that should be removed as well...

gmazzap commented 4 years ago

In deeb15a I removed the usage of current_filter I also merged current 2.x because i wanted to run integration tests to make sure this change did not break stuff.

And TBH it is easier to merge a PR when all checks are green.

widoz commented 4 years ago

Code looks fine to me, but LogActionSubscriber::update() still uses current_filter to determine log level. If we go this path, that should be removed as well...

Make totally sense.

In deeb15a I removed the usage of current_filter I also merged current 2.x because i wanted to run integration tests to make > sure this change did not break stuff. And TBH it is easier to merge a PR when all checks are green.

👍