inpsyde / modularity

A PSR-11 implementation for WordPress Plugins, Themes or Libraries.
https://inpsyde.github.io/modularity/
GNU General Public License v2.0
44 stars 4 forks source link

Bugfix/10 inconsistent modules status #11

Closed gmazzap closed 3 years ago

gmazzap commented 3 years ago

Bug fix / improvement.

See #10

See #10

No.

Besides of what described in #10 I've also implemented an additional status: MODULE_SKIPPED.

As I also documented in the README, this status is used in two cases:

I think this is more important now that we have more reasons for a module to not be marked as added, and it takes into account the issue of classes only implementing Module interfaces, that were an edge-case not handled in any way by the package. At least, now they leave a trace.

gmazzap commented 3 years ago

@Chrico @pablok34 I addressed all the comments. Please have a look again at the PR when you've time.