inpsyde / modularity

A PSR-11 implementation for WordPress Plugins, Themes or Libraries.
https://inpsyde.github.io/modularity/
GNU General Public License v2.0
46 stars 4 forks source link

Remove unnecessary parenthesis in condition #22

Closed widoz closed 1 year ago

widoz commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Remove unnecessary parenthesis in condition for Package::connect

What is the current behavior? (You can also link to an open issue here) Unnecessary parenthesis in condition

What is the new behavior (if this is a feature change)? No unnecessary parenthesis in condition

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) no

Other information:

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.24% // Head: 96.23% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (bee9f82) compared to base (65bc3f8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #22 +/- ## ============================================ - Coverage 96.24% 96.23% -0.01% Complexity 177 177 ============================================ Files 9 9 Lines 426 425 -1 ============================================ - Hits 410 409 -1 Misses 16 16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `96.23% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/inpsyde/modularity/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde) | Coverage Δ | | |---|---|---| | [src/Package.php](https://codecov.io/gh/inpsyde/modularity/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde#diff-c3JjL1BhY2thZ2UucGhw) | `97.77% <100.00%> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.