Closed o-samaras closed 1 year ago
Base: 96.86% // Head: 96.86% // No change to project coverage :thumbsup:
Coverage data is based on head (
599f28d
) compared to base (4e9c659
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @o-samaras!
@Chrico the PR looks very fine. If you can have a look and release a patch version that would be great.
Thanks 💪🏻 merged and created a 1.6.1 release: https://github.com/inpsyde/modularity/releases/tag/1.6.1
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fix
What is the current behavior? (You can also link to an open issue here) When using a child theme
ThemeProperties::basePath()
returns the parent theme's path. More information available in #26What is the new behavior (if this is a feature change)? Use
get_stylesheet_directory()
instead ofget_template_directory()
for retrieving the base path of the proper theme.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No
Other information: More information regarding the function usage and the difference for when having child themes available here.)