Closed shvlv closed 1 year ago
Patch coverage: 100.00
% and no project coverage change
Comparison is base (
602a940
) 96.88% compared to head (218d83b
) 96.88%.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix.
What is the current behavior? (You can also link to an open issue here) The
\Inpsyde\Modularity\Properties\PluginProperties::isActive
and\Inpsyde\Modularity\Properties\PluginProperties::isNetworkActive
methods don't work as expected because their arguments should be the path to the plugin file relative to the plugins directory (not absolute path).What is the new behavior (if this is a feature change)? New private property
pluginBaseName
was introduced to use withis_plugin_active
andis_plugin_active_for_network
WordPress functions. I don't know do we need the getter for the property.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No.
Other information: I targeted my previous PR because it's partially related. But it could be separated if needed.