Closed esurov closed 1 year ago
Right now we have in our composer.json
PHP 7.2 as minimum version. PHPUnit 9.x requires PHP 7.3 as min. So you probably need to change the constraint to "^8.5.21 || "^9.6.7""
to support all PHP versions.
@Chrico Good point. I have pushed another commit there.
Patch coverage has no change and project coverage change: -0.98
:warning:
Comparison is base (
eb14a9b
) 96.86% compared to head (c52eb0b
) 95.88%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This allows to update phpunit/phpunit with it's dependencies to 8 to 9 and correctly work with PHP8.*
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It bumps the version of phpunit to make coverage work on PHP 8
What is the current behavior? (You can also link to an open issue here)
Currently there is a problem described in the issue #30 https://github.com/inpsyde/modularity/issues/30
What is the new behavior (if this is a feature change)?
This PR fixed this issue.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, it does not.
Other information: