search

inpsyde / modularity

A PSR-11 implementation for WordPress Plugins, Themes or Libraries.
https://inpsyde.github.io/modularity/
GNU General Public License v2.0
44 stars 4 forks source link

Fix static analysis problems #35

Closed szepeviktor closed 4 months ago

szepeviktor commented 1 year ago

I am a phpstan guy, you are psalm guys. 💥

szepeviktor commented 1 year ago

I feel psalm will not understand some of these ...

Chrico commented 4 months ago

Hey @szepeviktor - we're using psalm. So if psalm does not understand the changes made for phpstan... mhm hard to merge 🙈 If you find a way to make it compat or fix it without breaking psalm: feel free to reopen 💪🏻

szepeviktor commented 4 months ago

All right @Chrico