inpsyde / modularity

A PSR-11 implementation for WordPress Plugins, Themes or Libraries.
https://inpsyde.github.io/modularity/
GNU General Public License v2.0
44 stars 4 forks source link

Require PHP 7.4, Fix CS and QA #48

Closed gmazzap closed 3 months ago

gmazzap commented 3 months ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix (for PHPCS config) + maintenance update

What is the current behavior? (You can also link to an open issue here)

PHPCS did not check anything.

What is the new behavior (if this is a feature change)?

No change in behavior. PHPCS now works (besides being updated).

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.93%. Comparing base (c6855a6) to head (b7a7fe4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #48 +/- ## ============================================ - Coverage 98.97% 98.93% -0.04% - Complexity 217 234 +17 ============================================ Files 10 10 Lines 588 566 -22 ============================================ - Hits 582 560 -22 Misses 6 6 ``` | [Flag](https://app.codecov.io/gh/inpsyde/modularity/pull/48/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/inpsyde/modularity/pull/48/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde) | `98.93% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inpsyde#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gmazzap commented 3 months ago

I would like to wait for the https://github.com/inpsyde/modularity/issues/47 before merging these updates.

@Chrico ok. I thought about doing it the other way around. But it is also fine get the generic hook out first. I'll comment there to agree on the hook name so we can move that forward.

gmazzap commented 3 months ago

Thanks for the review and the added test @tfrommen