Closed gmazzap closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.93%. Comparing base (
c6855a6
) to head (b7a7fe4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I would like to wait for the https://github.com/inpsyde/modularity/issues/47 before merging these updates.
@Chrico ok. I thought about doing it the other way around. But it is also fine get the generic hook out first. I'll comment there to agree on the hook name so we can move that forward.
Thanks for the review and the added test @tfrommen
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix (for PHPCS config) + maintenance update
What is the current behavior? (You can also link to an open issue here)
PHPCS did not check anything.
What is the new behavior (if this is a feature change)?
No change in behavior. PHPCS now works (besides being updated).
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: