inpsyde / wp-app-container

DI Container and related tools to be used at website level.
GNU General Public License v2.0
38 stars 2 forks source link

PHP 8.1 Compatibility for the 2.x Version Branch #16

Closed tfrommen closed 1 year ago

tfrommen commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR fixes two instances where the jsonSerialize method is not compatible with the definition of JsonSerializable::jsonSerialize(), which will result in a Deprecated notice on PHP 8.1.

What is the current behavior? (You can also link to an open issue here)

On PHP 8.1, you will see deprecation notices for the two instances, also triggering to "headers already sent" notices.

What is the new behavior (if this is a feature change)?

No notices.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

Other information: