search

inpsyde / wp-translation-downloader

Composer plugin to download WordPress translations
MIT License
45 stars 3 forks source link

Excludes are not working #10

Closed johnbillion closed 3 years ago

johnbillion commented 3 years ago

Describe the bug

The excludes config option is not functional.

To Reproduce

  1. Follow the instructions in the Exclude specific packages section of the project readme, except:
    • wpackagist-plugin/wordpress-seo doesn't exist
    • I'm using inpsyde/wp-translation-downloader at version ^1
  2. Run composer install
  3. Observe that WP Translation Downloader attempts to fetch translations for google-tag-manager despite it being excluded by the inpsyde/* rule

Expected behavior

WP Translation Downloader should not attempt to fetch translations for excluded depdencies.

System (please complete the following information):

Chrico commented 3 years ago

Hey @johnbillion !

Sorry for the late response. Just couldn't find much time to investigate that. It seems the call for $this->pluginConfig->doExclude() was missing in the update-logic.

I've add a fix for this in 1.x-branch. Could you pls verify that everything now works for you? :-) The same fix was applied to dev-master (version 2.x) including a Behat test to verify that the example from README actually works as described. See here: https://github.com/inpsyde/wp-translation-downloader/commit/45cc1ca528f379d5eea3fb1ba983c0a16dc7c6f8

Btw..you can switch to "inpsyde/wp-translation-downloader": "^2.0", we're still supporting Composer v1 in this version. :-)

johnbillion commented 3 years ago

Thanks! That's working nicely.

Chrico commented 3 years ago

Perfect! Created a new release 1.2.3 for the 1.x branch as well. 👍