input-output-hk / cardano-engineering-handbook

A handbook covering cross-project policies and information for projects in the Cardano Open Source Consortium
14 stars 0 forks source link

Triggering GitHub Actions from forks. #35

Closed coot closed 1 year ago

michaelpj commented 1 year ago

Is this a policy or a practice? I think it might be a practice, I don't see any SHOULDs in there.

coot commented 1 year ago

Good point, what about now?

michaelpj commented 1 year ago

I'm confused, what did you change?

coot commented 1 year ago

Click the compare button just above.

michaelpj commented 1 year ago

Ah right. We do RFC-style SHOULDs for things that are policy, so that's why I didn't spot it :)

coot commented 1 year ago

I changed the recommendation as I learned something about the pull_request and push events.

coot commented 1 year ago

@michaelpj, @abailly-iohk is there anything else you'd like me to address?