search

input-output-hk / cardano-explorer

Backend solution powering the cardano-explorer. :warning: See disclaimer below. :warning:
20 stars 11 forks source link

update ouroboros network depenency #273

Closed coot closed 4 years ago

coot commented 4 years ago

It seem me and @dcoutts worked on the same thing yesterday. This updates one step commit further (snockets); but let's first merge #272, I'll then resolve conflicts.

erikd commented 4 years ago

This updates one step commit further (snockets); but let's first merge #272, I'll then resolve conflicts.

I am not exactly sure what this means, but code that does not build should never be merged to master. In fact code that does not pass "Required" CI should never be merged to master.

coot commented 4 years ago

I am not exactly sure what this means, but code that does not build should never be merged to master.

This PR updates ouroboros-dependency up to one commit more than #272 (which includes snockets - an abstraction over sockets which allows to use clients over NamedPipes on Windows).

In fact code that does not pass "Required" CI should never be merged to master.

That's crystal clear, and that's never been my intention.

erikd commented 4 years ago

Closing this as it was sorted in another PR.