search

input-output-hk / cardano-sl

Cryptographic currency implementing Ouroboros PoS protocol
Apache License 2.0
3.76k stars 632 forks source link

Documentation outdated about cardano-wallet #2140

Closed jluttine closed 6 years ago

jluttine commented 6 years ago

Hi! According to docs, there should a CLI wallet executable called cardano-wallet: https://cardanodocs.com/technical/cli-options/#cardano-wallet

I haven't found any instructions on how to compile it or where to find it. Where can I find it?

In the build instructions https://github.com/input-output-hk/cardano-sl/blob/master/docs/how-to/build-cardano-sl-and-daedalus-from-source-code.md#nix-build-mode-recommended only cardano-wallet-hs2purs executable is mentioned.

jluttine commented 6 years ago

Also, the docs state: "Please notice that wallet web API is available only if you run a node with --wallet option." in https://cardanodocs.com/technical/wallet-backend/#wallet-backend-api

However, I tried running both cardano-node and cardano-node-simple with --wallet flag but both raised an error that it's an invalid option. So what is the node executable I should pass --wallet flag to?

fschr commented 6 years ago

I second this issue.

One of three things must be the case:

  1. cardano-wallet used to be, but is no longer included in Cardano SL.
  2. cardano-wallet is not yet a part of any stable branch.
  3. cardano-wallet is included in the cardano-sl-1.0 branch, but neither of us see how to build it.
gromakovsky commented 6 years ago

cardano-wallet was renamed to cardano-node. --wallet flag was removed. Those docs are very outdated 😔

fschr commented 6 years ago

@gromakovsky Thank you! I am planning to build cardano-wallet (now cardano-node) in a couple days. If the docs aren't updated by that time, I'll submit a PR.

morenoh149 commented 6 years ago

reviewing https://cardanodocs.com/technical/cli-options/ and https://github.com/input-output-hk/cardanodocs.com/commits/master/_docs/technical/2017-01-01-cli-options.md looks like references to cardano-wallet have been removed. This issue should be closed.

niespodd commented 6 years ago

@gromakovsky The documentation still refers to the outdated --wallet in the Wallet Backend spec section.