search

input-output-hk / cardano-sl

Cryptographic currency implementing Ouroboros PoS protocol
Apache License 2.0
3.77k stars 630 forks source link

[SUGGESTION]Mnemonic generation on a node's side #3976

Open Fell-x27 opened 5 years ago

Fell-x27 commented 5 years ago

Hi! According to this documentation, an API client should generate and provide a mnemonic code to the node, if it want to create a new wallet. But it can cause a collisions problem, if the client uses it's own (read as 'buggy') implementation of BIP39 instead of official one. And if this client become a public software, it will too late, when collisions begin to appear.

Probably, the better solution is generate seed and mnemonic on the node and return it to the client within an API "create" response data-section?

rvl commented 5 years ago

Hi! Good idea. The next version (2.1.0) provides a utility cardano-generate-mnemonic command, but no API endpoint.