avieth commented 4 years ago

It's possible for the same address to be resolved from different DNS names. The subscription system now recognizes this and avoids attempting to subscribe to the same IP address more than once concurrently.

This means you can now give the same domain name multiple times in the subscription specification, and the system will attempt to subscribe to different addresses from each of them concurrently. That's useful when we expect the names to give multiple addresses.

Description

Linked issue

Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[ ] I have read the style guide document, and my code follows the code style of this project.
[ ] If my code deals with exceptions, it follows the guidelines.
[ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see docs/how-to/bors.md.

tatyanavych commented 4 years ago

Please, add relevant CHANGELOG entry.

avieth commented 4 years ago

Please, add relevant CHANGELOG entry.

Added.

avieth commented 4 years ago

Hydra failing with

/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/v1ac6kxwfz8wh901ymbf6i13c4lmwbmf-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
unpacking sources
unpacking source archive /nix/store/x9h5l51wg3axgzbra3vbn9ahsn8jdw46-infra
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: Resource temporarily unavailable
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/jvav8sqn64g23p3x0is4l0ippmrz7jk1-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
cp: cannot create directory '': No such file or directory
do not know how to unpack source archive /nix/store/x9h5l51wg3axgzbra3vbn9ahsn8jdw46-infra
builder for '/nix/store/5ggzg156p7dgcy377fk76jnjpgp9gsn6-cardano-sl-infra-3.1.0-lib-cardano-sl-infra.drv' failed with exit code 1

disassembler commented 4 years ago

bors r+

iohk-bors[bot] commented 4 years ago

input-output-hk / cardano-sl

DNS subscription proper fallback/valency #4243

Description

Linked issue

Type of change

Developer checklist

Testing checklist

QA Steps

Screenshots (if available)

How to merge

Build succeeded