input-output-hk / cardano-wallet-legacy

Official Wallet Backend & API for Cardano-SL
https://input-output-hk.github.io/cardano-wallet/
MIT License
21 stars 12 forks source link

Node Monitoring API Docs are unpolished #306

Open Anviking opened 5 years ago

Anviking commented 5 years ago
Release Operating System Cause
next Windows & OSX & Linux) Code

Context

In addition to the wallet api docs, there is also the node monitoring api docs.

Steps to Reproduce

  1. launch wallet
stack exec -- cardano-wallet-server \                            
    --node-id                    edge                                   \
    --system-start               0                                      \
                                                                                                             \
    --topology                   state-integration/topology/edge.json   \
    --configuration-file         test/integration/configuration.yaml    \
                                                                                                             \
    --db-path                    state-integration/db                   \
     --wallet-db-path             state-integration/wallet-db            \
    --wallet-rebuild-db                                                 \
                                                                                                             \
    --wallet-api-address         127.0.0.1:8090                         \
    --wallet-doc-address         127.0.0.1:8190                         \
    --node-api-address           127.0.0.1:8080                         \
    --node-doc-address           127.0.0.1:8180                         \
                                                                                                             \
    --tls-ca-cert                state-integration/tls/edge/ca.crt      \
    --tls-wallet-server-cert     state-integration/tls/edge/server.crt  \
    --tls-wallet-server-key      state-integration/tls/edge/server.key  \
    --tls-node-client-cert       state-integration/tls/edge/client.crt  \
    --tls-node-client-key        state-integration/tls/edge/client.key  \

Visit https://127.0.0.1:8180/docs/v1/index/#tag/Info

Expected behavior

Nice docs

Actual behavior

skarmavbild 2019-02-05 kl 12 41 42

Resolution Plan

PR

Number Base
input-output-hk/cardano-sl#4072 develop

QA

Anviking commented 5 years ago

So we could do either:

skarmavbild 2019-02-11 kl 16 39 10

or

skarmavbild 2019-02-11 kl 16 42 43

🤔

akegalj commented 5 years ago
  • notice the #null

:man_facepalming:

Anviking commented 5 years ago

@KtorZ your advice would be helpful here

Particularly if we

KtorZ commented 5 years ago

Also, there's no real "legacy" node API (we've already cleaned that out and kept what was useful for ops). The API isn't perfect as it is to be 100% fair, and @cleverca22 already communicated on a few points they'd change.

Yet, we won't likely be spending any time on that. So, fixing the doc to better reflect what the API currently is, is the best we can do. About the tags, what would you do @Anviking ?