input-output-hk / cardano-wallet-legacy

Official Wallet Backend & API for Cardano-SL

https://input-output-hk.github.io/cardano-wallet/

MIT License

21 stars 12 forks source link

[220] Add NewTransactionZeroAmountCoin #318

Closed paweljakubas closed 5 years ago

paweljakubas commented 5 years ago

[220] Finishing error

#220

Overview

[x] I have added ZeroAmountOutput error together with tests

Comments

It was seen that one cannot construct transactions with zero amount output as in the current version it can incur long response times. The decision was to forbid it on the level of wallet by introduction of respective error. When it will be supported underneath it can be revoked though (eg. during Shelley era)

KtorZ commented 5 years ago

Actually. Why don't we even fix that at the API-level as-well ?

https://input-output-hk.github.io/cardano-wallet/#tag/Transactions%2Fpaths%2F~1api~1v1~1transactions%2Fpost

I mean, here, if we make sure that the amount can't be negative or null then we even prevent such transactions from making it into the kernel.