input-output-hk / cardano-wallet-legacy

Official Wallet Backend & API for Cardano-SL
https://input-output-hk.github.io/cardano-wallet/
MIT License
21 stars 12 forks source link

Do not require an account id for importing addresses #320

Closed KtorZ closed 5 years ago

KtorZ commented 5 years ago

#258

Overview

Comments

Actually, we were sort-of ignoring it already and the endpoint was misleading. Cardano addresses embed their corresponding account index inside them, therefore, when importing addresses, we only care about the root master key (and therefore, the root id). The account ix comes from the address anyway

piotr-iohk commented 5 years ago

@KtorZ perhaps you might want to update also ->

(not sure, the latter will update automatically?)

KtorZ commented 5 years ago

Indeed. And I'll also update the manual tests instruction / scripts. Thinking about getting yours merged before.

piotr-iohk commented 5 years ago

No probs, I can update manual tests under #319.

KtorZ commented 5 years ago

Updated manual tests, API layout and Swagger documentation :+1:

piotr-iohk commented 5 years ago

:+1: Feel free to merge. I'll add tests in #319 on the top of it if that's ok.