search

input-output-hk / cardano-wallet-legacy

Official Wallet Backend & API for Cardano-SL
https://input-output-hk.github.io/cardano-wallet/
MIT License
21 stars 12 forks source link

Prefilter FO-wallets and EO-wallets, in list-handlers. #335

Closed denisshevchenko closed 5 years ago

denisshevchenko commented 5 years ago

#336

Overview

Comments

KtorZ commented 5 years ago

I believe this ended up in the wrong abstraction layer. We duplicated logic a bit everywhere when it comes to identifying F.O. wallets vs E.O. wallets. Instead, we could / should piggy-back on the DB layer to provide us with the right wallets when we ask for them. Outside of the Wallet Layer.

Furthermore, there's one question we keep asking about wallets and it's "is this wallet fully-owned or not?". We must have a clear AND UNIQUE way of giving an answer to that question. It is not okay to have bits of duplicated logic which answers exactly this question :+1: