Make EO endpoints to manipulate EO wallets and FO to manipulate FO wallets only

[piotr-iohk]

Context

While testing #331 we have observed that one can manipulate EOS wallets with FO endpoints and FO wallets with EOS endpoints. In particular:

• You are able to list EOS wallets with FO enpoint GET /api/v1/wallets.
• You can successfully delete EOS wallet with FO endpoint and vice versa. (EOS with DELETE /api/v1/wallets/{walletId} and FO with DELETE /api/v1/wallets/externally-owned/{walletId})
• You can list EOS wallet with FO endpoint GET /api/v1/wallets/{walletId} (here you cannot do otherwise, and trying to get FO wallet with EOS enpoint results in WalletNotFound - which is expected I suppose)
• You can update EOS wallets with FO endpoint and vice-versa (here, after updating one or another with its counterpart endpoint - an error is returned by the API, still wallets are updated)

There were integration tests added for that under #331, they are currently failing:

  EOSWALLETS_DELETE_02 - cannot delete FO wallet with EOS endpoint FAILED [1]
  EOSWALLETS_DELETE_02 - cannot delete EOS wallet with FO endpoint FAILED [2]
  EOSWALLETS_DETAILS_01 - cannot get EOS wallet with FO endpoint FAILED [3]
  EOSWALLETS_LIST_01 - cannot get EOS wallets with FO endpoint FAILED [4]
  EOSWALLETS_LIST_01 - cannot get FO wallets with EOS endpoint FAILED [5]
  EOSWALLETS_UPDATE_01 - cannot update FO wallets with EOS endpoint FAILED [6]
  EOSWALLETS_UPDATE_01 - cannot update EOS wallets with FO endpoint FAILED [7]

Decision

Manipulation with EO wallets must be restricted only to EO endpoints. Manipulation with FO wallets must be restricted only to FO endpoints.

Acceptance Criterias

See ^. Integration tests mentioned here should pass.

---

Development Plan

PR

Number	Base
#335	develop
#337	develop

QA

Criteria	Coverage
?	-

---

Retrospective

[denisshevchenko]

All tests are passed now, except this one: EOSWALLETS_LIST_01 - cannot get FO wallets with EOS endpoint FAILED [5]

[piotr-iohk]

This test fails due to the fact Eos wallets list endpoint fails with error WalletNotFound, which still needs to be fixed.