search

input-output-hk / cardano-wallet-legacy

Official Wallet Backend & API for Cardano-SL
https://input-output-hk.github.io/cardano-wallet/
MIT License
21 stars 12 forks source link

[BIP44-239] Extend newTx to EO wallets #340

Open uroboros opened 5 years ago

uroboros commented 5 years ago

https://github.com/input-output-hk/cardano-wallet/issues/239

#

Overview

Comments

These changes add a new capability (new Tx for EO wallets) and does not test it yet. Existing tests for "newTx for HdRnd wallets" are still satisfied so we can be sure that this does not break any existing functionality.

Since both @piotr-iohk and I want to test this new functionality next (on API and Kernel level respectively) I suggest we review/merge this without tests to allow concurrent work between us.

NOTE: Adding tests for this on kernel level requires generalising the NewPayment Tests to EO wallets. These tests are also used by Tx and TxMeta tests, which also need to be generalised to EO wallets.

denisshevchenko commented 5 years ago

LGTM, however I'm not deeply in context..