search

input-output-hk / daedalus

The open source cryptocurrency wallet for ada, built to grow with the community
https://daedaluswallet.io/
Apache License 2.0
1.23k stars 297 forks source link

The option to "send remaining balance back to source address (explicitly)" in Daedalus #1508

Open RajaMBZ opened 5 years ago

RajaMBZ commented 5 years ago

Daedalus lets you use the new addresses (for better privacy) to get back the remaining balance of the Daedalus wallet for all the transactions you make. However, this shouldn't be made compulsory. For example, in the initial version of ZECmate Swing Wallet, it was the same case like the current one in Daedalus, but then they introduced the option to "send remaining balance back to source address (explicitly)", which has been working good ever since. IMO, Daedalus should get a similar function as well, as it helps if you wanna keep your remaining balance in the same address as before. For example, if I create a paper wallet through Daedalus and I use it, later on, I can keep the access to that address even after I once send the ADA from it. However, in order to do that right now, I've to re-send the ADA to the sending address. If this could be made through a function, it'll be very much convenient.

nikolaglumac commented 5 years ago

@KtorZ can you please comment on this? Thanks!

nikolaglumac commented 5 years ago

cc @darko-mijic

KtorZ commented 5 years ago

The backend doesn't leave much flexibility regarding the choice of the change address at the moment. We had plan to expose a more granular API endpoint allowing API clients to entirely specify inputs and outputs themselves (by-passing the wallet internal input selection and change generation).

Yet here, Daedalus would probably need something that sits in-between this and the current situation, still delegating the input selection to the backend, but allowing Daedalus to specify an explicit change address. From the top of my head, this sounds pretty easy to achieve with the current API and wallet design (could imagine an extra optional field force_change_address when submitting a payment, if set, the backend would use that address as a change address instead of generating a new one).

RajaMBZ commented 5 years ago

@KtorZ That's exactly what I meant; the explicit change of remaining balance address instead of getting a new one created. It'd be great if we can have that feature in future.

nikolaglumac commented 3 years ago

@rvl can you please create a card for this in cardano-wallet backlog?

cc @darko-mijic

rvl commented 3 years ago

OK https://jira.iohk.io/browse/ADP-701

nikolaglumac commented 3 years ago

Thanks!