input-output-hk / daedalus

The open source cryptocurrency wallet for ada, built to grow with the community
https://daedaluswallet.io/
Apache License 2.0
1.23k stars 297 forks source link

Support Export of xPub Key #2345

Closed michaeljfazio closed 3 years ago

michaeljfazio commented 3 years ago

It's tax time soon and I'd love it if I could use my normal tax tracking service so that I can get a consolidated view of what I need to pay the man. Problem is, they don't support xPub for Cardano and it seems this is because they claim the various Cardano wallets don't support easily extracting the xPub address. So, I'm forced to enter every wallet address manually, which kind of defeats the purpose of it all in the first place.....

It would be great if there were a convenient way to get the xPub address from the Daedalus UI similar to how you can do it in LedgerLive. I raised a ticket with CoinTracker.io referencing this issue in the hope that the addition of this feature may enable them to give their users a better portfolio/tax tracking experience.

nikolaglumac commented 3 years ago

We have the UI for this feature already ready (implemented in https://github.com/input-output-hk/daedalus/pull/2271) and we will enable it as soon as we get the supporting API ready on the cardano-wallet side.

Here's how it looks: 101918428-32da0880-3b7e-11eb-9ab8-ccb5920f5ed8 101918587-5f8e2000-3b7e-11eb-87e2-7f556e67911e 102502995-1e8d8400-4034-11eb-8e00-172881e2949c 102782815-d1b8ee80-434e-11eb-861f-3ec450e045f4

nikolaglumac commented 3 years ago

This feature has been implemented in https://github.com/input-output-hk/daedalus/pull/2429 and it is to be released on Daedalus Flight today. You can expect it on Daedalus Mainnet a bit later this week. Thank you for the patience! 🙏

nikolaglumac commented 3 years ago

This has been implemented and released in the scope of Daedalus Mainnet 4.0.3: https://github.com/input-output-hk/daedalus/releases/tag/4.0.3 Thanks for the patience 🙏

dgellow commented 3 years ago

@nikosbentenitis Should I be able to find my wallet on https://explorer.cardano.org/en.html by copy-pasting the public key? That's not the case for me, no result is found. I'm using a Ledger Nano S wallet, not sure if that matters here.

nikolaglumac commented 3 years ago

No. Explorer is not expected to return any results based on your wallet's public key.

nikolaglumac commented 3 years ago

@dgellow later on, new functionality will enable the import of read-only wallets from a wallet's public key. These view-only wallets will show the wallet's balance and transaction history without the ability to spend funds, change delegation preferences, or modify anything in the wallet. View-only wallets will be useful for auditing and similar purposes.

For now, I think you can only try importing the public key into services such as https://koinly.io/ or https://www.cointracker.io/

dgellow commented 3 years ago

By curiosity I tried to import a wallet's public key with Accointing but that doesn't seem to work. Of course that could be an issue on their side.

nikolaglumac commented 3 years ago

They most likely do not have support for Cardano public keys yet.

dgellow commented 3 years ago

Ok, I think that I understand. They do have support for "XPubKey" which is what you describe as "view-only wallet" as far as I understand.

nikolaglumac commented 3 years ago

Indeed. Still, it is important to have the same implementation.

dgellow commented 3 years ago

Thanks :)

nikolaglumac commented 3 years ago

Thanks for the feedback - it is greatly appreciated! :-)

edwmurph commented 3 years ago

For now, I think you can only try importing the public key into services such as https://koinly.io/ or https://www.cointracker.io/

i updated my daedalus to 4.0.3 but when i try to add the "Wallet public key" as a public address wallet to my cointracker, it's failing with "Failed to add wallet. Please check the values below." i also confirmed that cointracker isn't even able to fetch the balance via https://www.cointracker.io/wallet/cardano and is failing on that page with "Failed to fetch wallet balance". is this cointracker integration actually working for anyone?

nikolaglumac commented 3 years ago

I believe https://www.cointracker.io/wallet/cardano accepts wallet address and not public account key.

nikolaglumac commented 3 years ago

I can confirm it works if you paste in a valid wallet address: Screenshot 2021-03-31 at 16 51 34

edwmurph commented 3 years ago

oh ya i've been able to manually put all the generated addresses for my daedalus wallet into my cointracker fine. i just currently dont see a way to import this new daedalus wallet public key into cointracker? it sounds like cointracker actually doesn't support importing cardano public keys yet

this is a pain point for me because i had to manually import all my generated addresses for my daedalus wallet into cointracker for taxes so im looking forward to the day when i can just give cointracker the one public key for my wallet

nikolaglumac commented 3 years ago

Sorry for that... I believe now the cointracker needs to be updated to handle import of the Cardano wallet account public keys.

michaeljfazio commented 3 years ago

oh ya i've been able to manually put all the generated addresses for my daedalus wallet into my cointracker fine. i just currently dont see a way to import this new daedalus wallet public key into cointracker? it sounds like cointracker actually doesn't support importing cardano public keys yet

this is a pain point for me because i had to manually import all my generated addresses for my daedalus wallet into cointracker for taxes so im looking forward to the day when i can just give cointracker the one public key for my wallet

This is correct. I’ve raised this with CoinTracker multiple times now. I suggest you lodge a support request with then and reference this issue so we can generate some visibility with them. Unfortunately they’re support is atrocious when it comes to this type of thing.

edwmurph commented 3 years ago

added a feature request to cointracker if anyone wants to upvote it to help get cointracker's attention on this https://feedback.cointracker.io/features/p/add-support-for-importing-transactions-via-xpub-cardano-daedalus-keys

airtonix commented 3 years ago

oh ya i've been able to manually put all the generated addresses for my daedalus wallet into my cointracker fine. i just currently dont see a way to import this new daedalus wallet public key into cointracker? it sounds like cointracker actually doesn't support importing cardano public keys yet

this is a pain point for me because i had to manually import all my generated addresses for my daedalus wallet into cointracker for taxes so im looking forward to the day when i can just give cointracker the one public key for my wallet

@edwmurph how? adding a hd ledger wallet only lets you put one address.

edwmurph commented 3 years ago

i added a new/separate public address wallet to cointracker for each of the generated addresses for my daedalus wallet into cointracker via https://www.cointracker.io/add_wallet

image

pedrocanelas commented 3 years ago

I'm so happy I found this post! Today I found Accounting and it is the first tracker that I managed to sync with Daedalus. I'm just wondering if is possible to see my ADA that was delegated. Are there extra settings or flow for it or I'm asking something impossible?

nikolaglumac commented 3 years ago

Not sure what you mean by "ada that was delegated"?

pedrocanelas commented 3 years ago

I'm using Accointing to track my ADA on Daedalus but when I stake my ADA delegating to a Pool, I can't see it anymore on Accointing. It makes sense because it left my wallet and now is in the pool but I'm wondering if there is still a way of keep tracking it on Accointing. For now, I managed to solve adding manually the amount of ADA that I have, I think this should be enough.

nikolaglumac commented 3 years ago

Ada that you delegate never leaves Daedalus so I am still not sure what you mean.

pedrocanelas commented 3 years ago

I opened Daedalus, went to Settings, copied my wallet address and I pasted it to connect to Accointing. On Accointing it shows I have 0 ADA. I assumed that happens because all my ADA is delegated. So what you are saying is that I should be able to still see, right?

nikolaglumac commented 3 years ago

What is the balance of the wallet shown in Daedalus?

pedrocanelas commented 3 years ago

On Daedalus, I can see my balance correctly. When I try to add a Cardano Wallet on Accounting and I enter the public key address found on Settings, Accointing shows I have nothing. Now reading again the thread, I see it should be an issue from Accointing side and the lack of possibility of reading the Public Key. 😕

nikolaglumac commented 3 years ago

Yes this sounds like an issue on their end :-(

pedrocanelas commented 3 years ago

Cointracker offers the option to add a wallet via Public Key but when I paste it, it says "Failed to add wallet. Please check the values below.". I will check with them. Thank you so much for the quick replies! :)

cecarlsen commented 6 months ago

I'm trying to track for tax using Koinly, and it seems they only support xpub keys, not the Cardano public key. As far as I can se, there is no easy way to export such a key from Daedalus. If anyone has a solution, please share.