search

input-output-hk / daedalus

The open source cryptocurrency wallet for ada, built to grow with the community
https://daedaluswallet.io/
Apache License 2.0
1.23k stars 297 forks source link

Messaging/ Alert system #2488

Open aleincsharp opened 3 years ago

aleincsharp commented 3 years ago

Hello everybody,

as a small pool operator, I currently stumble across overcrowded pools every day and what is even worse: Retired pools currently have a total of over 17 million ADAs delegated!

My idea was to implement a kind of messaging / alert system in Daedalus, where the delegator in the system receives a message, that he is currently staked in a pool that is either overcrowded or that the pool is retired.

Would this idea be a possible approach to draw attention to it?

P.S .: I have already introduced myself to @nikolaglumac as a developer and I hope to be able to contribute soon! :)

Arthur (WISE-Pool)

nikolaglumac commented 3 years ago

Hi Arthur :-)

Can you expand on the idea? What messaging/alert type do you have in mind? Also, we are limited to showing the alerts only once Daedalus is running. E.g. if you delegate and then don't run Daedalus for a year (during which time the SP you delegate to retires), we have no way to notify the user.

More info is greately appreciated!

Thanks!

timack commented 3 years ago

Thats an interesting idea ... but I wonder if this should be a 3rd party service maybe optionally initiated from within the wallet - ie. you could (optionally) provide your email and and pool id to a monitoring service who would email you if the pool over-saturates, goes down or gets retired. Then you you're not reliant on having to check the wallet to see if the pool is still active?

If I delegated and came back after a year to find out my pool had been retired for most of the previous year I'd be pretty mad.

But maybe such functionality is outside of the scope of the wallet's responsibility and the onus should be on the delegator to monitor their pool appropriately?

aleincsharp commented 3 years ago

Hi Arthur :-)

Can you expand on the idea? What messaging/alert type do you have in mind? Also, we are limited to showing the alerts only once Daedalus is running. E.g. if you delegate and then don't run Daedalus for a year (during which time the SP you delegate to retires), we have no way to notify the user.

More info is greately appreciated!

Thanks!

Of course, you can only send a notification when the application is running. First, a "warning message" could be displayed when someone wants to delegate to an overcrowded pool. It would also be important that the delegator receives a notification as soon as a pool is classified as retired.

At the first step a in-app alert system would be good and maybe a desktop push notification. Maybe a optional subscription from daedalus wallet with a email connection could be a possible second solution to reach delegators outside the application.

aleincsharp commented 3 years ago

Thats an interesting idea ... but I wonder if this should be a 3rd party service maybe optionally initiated from within the wallet - ie. you could (optionally) provide your email and and pool id to a monitoring service who would email you if the pool over-saturates, goes down or gets retired. Then you you're not reliant on having to check the wallet to see if the pool is still active?

If I delegated and came back after a year to find out my pool had been retired for most of the previous year I'd be pretty mad.

But maybe such functionality is outside of the scope of the wallet's responsibility and the onus should be on the delegator to monitor their pool appropriately?

Yes, this was also in my mind to create a API and link the wallet to a email or similar.

nikolaglumac commented 3 years ago

All of this would require Daedalus to be constantly running and that is not realistic. It is obviously a 3rd party service requirement that needs to be integrated with Daedalus.

As far as Daedalus goes the best we can do is to run a check to see if any of the wallets you have are delegated to a retired stake pool and raise an alert in case they are...

aleincsharp commented 3 years ago

As far as Daedalus goes the best we can do is to run a check to see if any of the wallets you have are delegated to a retired stake pool and raise an alert in case they are...

This would be a great step!

aleincsharp commented 3 years ago

All of this would require Daedalus to be constantly running and that is not realistic. It is obviously a 3rd party service requirement that needs to be integrated with Daedalus.

Do you have an idea how best to integrate with a 3rd party app to daedalus? A plugin, a api?

nikolaglumac commented 3 years ago

An API would do.

Asafkbalink commented 3 years ago

@aleincsharp PoolTool on android can provide you updates if the pool changed fees, became over-saturated or produced a new block. Regardless, this feature is important to have in Daedalus as well. Daedalus have wider adoption

aleincsharp commented 3 years ago

@aleincsharp PoolTool on android can provide you updates if the pool changed fees, became over-saturated or produced a new block. Regardless, this feature is important to have in Daedalus as well. Daedalus have wider adoption

Yes, the pooltool and adapools apps can do this. I am working currently on the API! Because this API is a part of my bigger platform/solution it takes more time for now. But i hope to get the first version online soon!

timack commented 3 years ago

This incident might have been the sort of thing a delegator would have wanted to know about - Pool operator increased margin to 99% just before the end of Epoch: https://twitter.com/SproutPool/status/1390036177407725568

aleincsharp commented 3 years ago

This incident might have been the sort of thing a delegator would have wanted to know about - Pool operator increased margin to 99% just before the end of Epoch: https://twitter.com/SproutPool/status/1390036177407725568

Yes, i am working on multiple notifications through telegram, email, twitter, etc. Because this project/API is a part of my new plattform (https://ada-data.eu/), it takes a little bit longer to implement.

nikolaglumac commented 3 years ago

@aleincsharp is that project of yours publicly available? AKA. open source?

aleincsharp commented 3 years ago

@aleincsharp is that project of yours publicly available? AKA. open source?

At the moment no, but i plan to do it, yes!

There is a lot to do, but unfortunately I don't have that much spare time with a normal job. I do it like many others in my spare time. I'll do my best and hurry up! :)

nikolaglumac commented 3 years ago

Thanks for all the efforts @aleincsharp! We need to open more direct communication in order to integrate your service within Daedalus. Perhaps you could prepare an architectural overview or a plan and present it to us in a call? We would be glad to push this forward in the 2nd part of May. cc @darko-mijic

aleincsharp commented 3 years ago

Thanks for all the efforts @aleincsharp! We need to open more direct communication in order to integrate your service within Daedalus. Perhaps you could prepare an architectural overview or a plan and present it to us in a call? We would be glad to push this forward in the 2nd part of May. cc @darko-mijic

With pleasure! I prepare a small architectural slide, then we can schedule a call. I'll have things ready by the middle of next week. Where can we talk directly? Here are my options: info@wise-pool.eu, https://twitter.com/wise_pool, Telegram: @Arthur_WISE, Discord: WISE#9925

nikolaglumac commented 3 years ago

I meant like Google Meet session.

aleincsharp commented 3 years ago

I meant like Google Meet session.

We can schedule the meeting on any platform. As it suits you best.

aleincsharp commented 3 years ago

Thanks for all the efforts @aleincsharp! We need to open more direct communication in order to integrate your service within Daedalus. Perhaps you could prepare an architectural overview or a plan and present it to us in a call? We would be glad to push this forward in the 2nd part of May. cc @darko-mijic

Hello @nikolaglumac ,

i am ready to show some pics about the architecture and share my ideas with you;). When you can schedule a meeting?

nikolaglumac commented 3 years ago

Hi @aleincsharp! That's great to hear! I'll reach out to you near the end of next week and we'll find a slot which works for all of us :-) Looking forward to it!

nikolaglumac commented 3 years ago

Hey @aleincsharp! 👋 I haven't forgotten about you - we've just been very busy and Darko is on vacation this week. This is why I would like to ask you to move our call to next week (Wednesday or Thursday). Let's continue via email - please reach on nikola.glumac@iohk.io Thanks!

hodlonaut commented 3 years ago

Has anything happened on this front since 20th of May? Just wondering...

aleincsharp commented 3 years ago

Has anything happened on this front since 20th of May? Just wondering...

Yes, working again on it after a forced break...will try to release first steps soon.