search

input-output-hk / daedalus

The open source cryptocurrency wallet for ada, built to grow with the community
https://daedaluswallet.io/
Apache License 2.0
1.23k stars 297 forks source link

FR - Add the support for transaction messages/comments/memos with onchain metadata (CIP-0020) #2613

Open gitmachtl opened 3 years ago

gitmachtl commented 3 years ago

Please implement transaction comment/description/memo field in Daedalus via onchain metadata addon that uses the metadata messaging from CIP-0020: https://github.com/cardano-foundation/CIPs/blob/master/CIP-0020/CIP-0020.md CardanoCommunityWallet and other tools implemented it already.

Yoroi for example has a MEMO field, but only usage is for internal memos. The transaction message is something other blockchains have implemented. We have the code for that since the Allegra fork. Its a method to just send additional information along with your transaction, like your invoice-number for example when you pay for something. I guess you don't make fiat bank transfers for invoices without any additional data in it (invoice-no, customer-no, etc.). Its the same with crypto transactions. When you are the receiver, it helps you to see what the incoming transactions are for. As a sender, you see in your history what the payment was for. We need this little addon to make it more mainstream imo. Why not cardanoscan? Yes, cardanoscan shows the data, but we are talking normal users here. You want that information in your wallet, not on a platform somewhere else. When you are a company f.e. , and you look at your fiat bank account, you see an incoming transfer with the invoice-no for example, you don't want to just see +$125,00 and than you have to guess what that amount was for, who sent it, etc by reaching out to a special banking website.

The message/comment/memo should be displayed as an additional info right beside the transaction history, as a dropdown, as a field, etc. Maybe leave it as it is with the metadata display, but we need an input field for an outgoing transaction. There is no need for all tools to support multiline input fields, if you just implement a single comment line, that would be cool too for the start. But the possibilities for the normal users are big. Others can even build automated reactions to transactions like that including this little metadata json addon, like automated emails "thx, we received your payment for invoice-no xxxxx".

nikolaglumac commented 3 years ago

@gitmachtl thanks for submitting this feature request. I have put it into our backlog. The product team will take care of prioritizing it and getting it ready for implementation. Thanks for the patience!

gitmachtl commented 3 years ago

Thank you very much, also added some additional implementation thoughts into the CIP. Like hiding the comment first under a "show unmoderated comment" button/drop-down like on the cardano explorer. Or to autoremove/autodelete urls, or really limit the character space to a handful of chars to prevent url/html code inception for example.

gitmachtl commented 3 years ago

CIP-0020 has been approved and merged into master

rcmorano commented 3 years ago

Any plans on integrating this CIP anytime soon? It would become very handy for a project we are working on.

Sunset17 commented 3 years ago

Is this to me?

nikolaglumac commented 3 years ago

Any plans on integrating this CIP anytime soon? It would become very handy for a project we are working on.

Not in the next couple of sprints due to Alonzo and other higher priority work. I will let you know once it gets scheduled for work. Thanks for the patience!