input-output-hk / dapps-certification-web

Certification as a service for the Cardano dApps platform
Apache License 2.0
5 stars 0 forks source link

[PLT-7608] Migrate Auditor Sign Certificates #20

Closed amnambiar closed 1 year ago

amnambiar commented 1 year ago

https://input-output.atlassian.net/browse/PLT-7608

BE PR - https://github.com/input-output-hk/dapps-certification/pull/90

@coderabbitai: ignore

Summary by CodeRabbit

coderabbitai[bot] commented 1 year ago

Walkthrough

This pull request introduces significant enhancements to the certification process, including a new CertificationMetadataForm component for capturing metadata, improved validation schemas, and refactored components for better maintainability. It also includes updates to the Redux store for user profile management and various styling adjustments.

Changes

File(s) Summary
src/components/CertificationMetadataForm/...,
src/pages/certification/components/CertificationMetadata/...
Introduced a new form component for capturing certification metadata with comprehensive validation rules.
src/components/CreateCertificate/...,
src/pages/auditing/reportUpload/...
Refactored existing components, improved form fields handling, and enhanced error display.
src/components/DAPPScript/... Updated the DApp script component to support dynamic input fields and deep error capturing.
src/components/Modal/Modal.tsx Enhanced the Modal component to accept additional props for customization.
Various .scss files Adjusted styles across multiple components for better UI consistency.
src/pages/certification/components/AuditorRunTestForm/AuditorRunTestForm.tsx Replaced direct API calls with dispatch actions for updating user profiles.
src/store/slices/auth.slice.ts Added new thunks for fetching and updating user profiles, and updated the reducer accordingly.
src/utils/utils.ts Added a utility function to transform empty string values in an object to null.

"With each commit we make, our codebase takes shape 🐇💻,
Like a garden growing, it's a beautiful landscape 🌷.
From forms to styles, and state in the store 📝,
Our app is evolving, becoming so much more 🚀!"

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - Mention `@coderabbitai` in any *review comment* for bot assistance. - Note: Review comments are made on code diffs or files, not on the PR overview. ### Pause Incremental Reviews - Insert `@coderabbitai: ignore` in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
RSoulatIOHK commented 1 year ago

The metadata is not prefilled for me:

https://github.com/input-output-hk/dapps-certification-web/assets/117812549/6a7df07e-17bd-4796-9c1f-f0876ba7ee7e

This was done on: BE: https://dapps-certification.scdev.aws.iohkdev.io/ FE: PR20 latest commit DApp: minimal-ptt-examples vesting latest commit

The whole form behaves in a strange manner:

https://github.com/input-output-hk/dapps-certification-web/assets/117812549/ec62e000-8812-4d9e-873f-a1db63e04067

amnambiar commented 1 year ago

The issue was with commit https://github.com/input-output-hk/dapps-certification-web/pull/20/commits/30150a4c7643858214b6132559f10b99f71f0c81 , to prefill form fiels (name, email, twitter, website) from profile fields.

Have reverted the commit to address this in a new bug PLT-7662.